Skip to content

Fix data normalization methods#36

Open
zimenglyu wants to merge 4 commits intomainfrom
zimeng/fix_normalization
Open

Fix data normalization methods#36
zimenglyu wants to merge 4 commits intomainfrom
zimeng/fix_normalization

Conversation

@zimenglyu
Copy link
Collaborator

Describe your changes

Fix the data normalization methods so that data normalization bounds come from training data only

What type is this change?

  • Bug fix
  • New feature

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have tested on MAC OS system
  • I have tested on Ubuntu system
  • I have tested on the RIT research cluster and updated the spack packages for compiling
  • My changes generate no new warnings
  • If the PR is related to a new feature, I added the running scripts for the new feature

How Has This Been Tested?

Added this log information for sanity check, the normalization bounds should only come from testing files:
Log::debug("Training file: %d, min: %lf, max: %lf\n", train_index, current_min, current_max);

@zimenglyu zimenglyu self-assigned this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant